Blocks upload: Don't do cleanUp when meta.json fails to upload. #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
Failed |
OGKevin
reviewed
Dec 15, 2020
Signed-off-by: Peter Štibraný <[email protected]>
OGKevin
approved these changes
Dec 15, 2020
2 tasks
|
This is a very interesting case. Thank you for your work on this! AIUI pragmatically this means that the meta.json file would have to appear within 30 seconds because we do a |
GiedriusS
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, when upload of
meta.jsonfile fails, it will actually appear on the bucket eventually. S3 has been observed to behave like this when it reports 503 "SlowDown" error. Currentlyblock.UploadcallscleanUpto delete partially uploaded block, but ifmeta.jsoncan still appear in the bucket later, this actually creates invalid block – withmeta.jsonfile only, but no index or chunks.Changes
This PR removes call to
cleanUpif onlymeta.jsonupload fails. Ifmeta.jsonhas really failed, this will result into partial block (withoutmeta.json) and be eventually removed by other components, or upload will be retried by Shipper. But at least it won't generate corrupted blocks.For more details, see discussion at https://cloud-native.slack.com/archives/CL25937SP/p1608021430416900.
Verification
Added unit test.