Fix query frontend regression on release v0.17.0 #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries api endpoints (thanos-io#3444) Signed-off-by: Alexander Tunik <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
changed the title
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
fix-query-frontend-series-response
branch
from
a54b5dc to
dc4d2f2
Compare
|
Umm, I don't know how can I update the changelog since there is no section for v0.17.0. Do I need to add the change to the unreleased part? |
|
Just hit this today, anything I can help with to ensure this gets merged and a hotfix is released? |
|
Correct @yeya24 - we will create v0.17.1 section from it. cc @metalmatze |
metalmatze
pushed a commit
to metalmatze/thanos
that referenced
this pull request
Dec 9, 2020
* query-frontend: make POST-request to downstream url for labels and series api endpoints (thanos-io#3444) Signed-off-by: Alexander Tunik <[email protected]> * remove default response cache config Signed-off-by: Ben Ye <[email protected]> * ensure order when merging multiple responses Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]>
bwplotka
added a commit
that referenced
this pull request
Dec 9, 2020
* Fix query frontend regression on release v0.17.0 (#3480) * query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444) Signed-off-by: Alexander Tunik <[email protected]> * remove default response cache config Signed-off-by: Ben Ye <[email protected]> * ensure order when merging multiple responses Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]> * *: Set debug.SetPanicOnFault(true) so we can recover seg faults. (#3498) Signed-off-by: Bartlomiej Plotka <[email protected]> * Prepare v0.17.1 release (#3505) Signed-off-by: Matthias Loibl <[email protected]> * fix index out of bound bug when comparing ZLabelSets (#3520) * fix index out of bound bug when comparing ZLabelSets Signed-off-by: Ben Ye <[email protected]> * fix param parsing error message Signed-off-by: Ben Ye <[email protected]> * address comment feedbacks Signed-off-by: Ben Ye <[email protected]> * compact: do not cleanup blocks on boot (#3532) Do not cleanup blocks on boot because in some very bad cases there could be thousands of blocks ready-to-be deleted and doing that makes Thanos Compact exceed `initialDelaySeconds` on k8s. Signed-off-by: Giedrius Statkevičius <[email protected]> * Prepare v0.17.2 (#3543) Signed-off-by: Matthias Loibl <[email protected]> * Properly rebase CHANGELOG.md after merging release-0.17 Signed-off-by: Matthias Loibl <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3465
Changes:
Verification