Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Compactor should be able to handle retention #2782

Closed
posix4e opened this issue Jun 18, 2020 · 3 comments · Fixed by #2808
Closed

Feature: Compactor should be able to handle retention #2782

posix4e opened this issue Jun 18, 2020 · 3 comments · Fixed by #2808
Labels
component: compact needs-more-info

Comments

@posix4e
Copy link

posix4e commented Jun 18, 2020

Thanos, Prometheus and Golang version used:
Newest

Object Storage Provider:
Any. In this case I'm using minio

It would be delightful to be able to have thanos automatically compact away results older than a certain number of days. We are very privacy centric at our company.
@GiedriusS
Copy link
Member

Hi! It does via the --retention.X flags as described here: https://thanos.io/components/compact.md/#downsampling-resolution-and-retention. Is there something in there that doesn't work for your use case exactly?

@the-yash
Copy link

Hi. I have set my retention flags,

- "--retention.resolution-raw=4h"
- "--retention.resolution-5m=16h"
- "--retention.resolution-1h=3d"

If I understand correctly, I should not be having any data after 3 days. However, I can query data older than that as well. Why is this happening?

@posix4e
Copy link
Author

posix4e commented Jun 21, 2020 via email

GiedriusS added a commit to GiedriusS/thanos that referenced this issue Jun 25, 2020
@GiedriusS
docs: compact: add blurb about how retention policy works
c8f76e3 
Add some verbiage that explains when exactly do the blocks get deleted.

Closes thanos-io#2782.

Signed-off-by: Giedrius Statkevičius <[email protected]>
@GiedriusS GiedriusS mentioned this issue Jun 25, 2020
Merged
2 tasks
bwplotka pushed a commit that referenced this issue Jun 25, 2020
@GiedriusS
docs: compact: add blurb about how retention policy works (#2808)
f078fae 
Add some verbiage that explains when exactly do the blocks get deleted.

Closes #2782.

Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: compact needs-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: compact: add blurb about how retention policy works GiedriusS/thanos
3 participants
@posix4e @GiedriusS @the-yash