Remove hasts field from Exemplar message

Signed-off-by: Deepak <[email protected]>
thanos-io · Mar 19, 2021 · 8fdd90c · 8fdd90c
1 parent 7b49b71
commit 8fdd90c
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 76 deletions.
diff --git a/pkg/exemplars/exemplarspb/custom.go b/pkg/exemplars/exemplarspb/custom.go
@@ -91,16 +91,12 @@ func (e1 *Exemplar) Compare(e2 *Exemplar) int {
 	if d := labels.Compare(e1.Labels.PromLabels(), e2.Labels.PromLabels()); d != 0 {
 		return d
 	}
-
-	if e1.Hasts && e2.Hasts {
-		if e1.Ts < e2.Ts {
-			return 1
-		}
-		if e1.Ts > e2.Ts {
-			return -1
-		}
+	if e1.Ts < e2.Ts {
+		return 1
+	}
+	if e1.Ts > e2.Ts {
+		return -1
 	}
-
 	if d := big.NewFloat(e1.Value).Cmp(big.NewFloat(e2.Value)); d != 0 {
 		return d
 	}

diff --git a/pkg/exemplars/exemplarspb/rpc.pb.go b/pkg/exemplars/exemplarspb/rpc.pb.go
diff --git a/pkg/exemplars/exemplarspb/rpc.proto b/pkg/exemplars/exemplarspb/rpc.proto
@@ -51,5 +51,4 @@ message Exemplar {
     ZLabelSet labels = 1 [(gogoproto.jsontag) = "labels", (gogoproto.nullable) = false];
     double value = 2 [(gogoproto.jsontag) = "value"];
     int64 ts = 3 [(gogoproto.jsontag) = "timestamp"];
-    bool hasts = 4 [(gogoproto.jsontag) = "hasTimestamp"];
 }