Call _convert_stream_to_dict_format in commands instead of in API fun…

…ction
th2-net · Nov 29, 2024 · 3e2aa84 · 3e2aa84
1 parent d16a93a
commit 3e2aa84
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/release_notes.md b/release_notes.md
@@ -262,4 +262,5 @@ BugFixes without ticket
 
 ## BugFixes
 1. [TH2-5222] - Fix `DownloadMessagesByPageGzip`, it constructed `DownloadMessagesByPageByGroupsGzip` incorrectly.
-2. [TH2-5243] - Fix backward compatibility issues with `GetMessagesByBookByGroups` and `GetMessagesByPageByGroups`.
+2. [TH2-5243] - Fix backward compatibility issues with `GetMessagesByBookByGroups` and `GetMessagesByPageByGroups`,
+   added 'limit' and 'search_direction' parameters to 'post_download_messages'.
diff --git a/th2_data_services/data_source/lwdp/commands/http.py b/th2_data_services/data_source/lwdp/commands/http.py
@@ -38,7 +38,7 @@
 from th2_data_services.data_source.lwdp.interfaces.command import IHTTPCommand
 from th2_data_services.data_source.lwdp.data_source.http import DataSource
 from th2_data_services.data_source.lwdp.source_api.http import API
-from th2_data_services.data_source.lwdp.streams import Streams, Stream
+from th2_data_services.data_source.lwdp.streams import Streams, Stream, _convert_stream_to_dict_format
 from th2_data_services.utils.sse_client import SSEClient
 from th2_data_services.data_source.lwdp.adapters.adapter_sse import (
     SSEAdapter,
@@ -1533,7 +1533,7 @@ def __init__(
         self._page = page
         self._book_id = book_id
         self._groups = groups
-        self._streams = streams
+        self._streams = _convert_stream_to_dict_format(streams)
         self._sort = sort
         self._response_formats = response_formats
         self._fast_fail = fast_fail
@@ -1661,7 +1661,7 @@ def __init__(
         if isinstance(end_timestamp, int):
             self._end_timestamp = UnixTimestampConverter.to_nanoseconds(end_timestamp)
         self._groups = groups
-        self._streams = streams
+        self._streams = _convert_stream_to_dict_format(streams)
         self._sort = sort
         self._response_formats = response_formats
         self._book_id = book_id
@@ -1870,7 +1870,7 @@ def __init__(
         if isinstance(end_timestamp, int):
             self._end_timestamp = UnixTimestampConverter.to_nanoseconds(end_timestamp)
         self._groups = groups
-        self._streams = streams
+        self._streams = _convert_stream_to_dict_format(streams)
         self._sort = sort
         self._response_formats = response_formats
         self._book_id = book_id
@@ -2359,7 +2359,7 @@ def __init__(
         self._page = page
         self._book_id = book_id
         self._groups = groups
-        self._streams = streams
+        self._streams = _convert_stream_to_dict_format(streams)
         self._sort = sort
         self._response_formats = response_formats
         self._fast_fail = fast_fail

diff --git a/th2_data_services/data_source/lwdp/source_api/http.py b/th2_data_services/data_source/lwdp/source_api/http.py
@@ -375,8 +375,6 @@ def post_download_messages(
             URL for downloading messages and dictionary for request body.
         """
 
-        streams = _convert_stream_to_dict_format(streams)
-
         kwargs = {
             "resource": "MESSAGES",
             "startTimestamp": start_timestamp,