Add ability to retreive grpc service instance from context #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cordwelt
reviewed
Feb 8, 2023
| @@ -32,6 +33,7 @@ class HandlerContext( | |||
| private val channelFactory: ChannelFactory, | |||
| private val getDictionary: (DictionaryType) -> InputStream, | |||
| private val sendEvent: (Event) -> Unit, | |||
| private val grpcRouter: GrpcRouter | |||
There was a problem hiding this comment.
Let's pass a method reference instead of the whole router
There was a problem hiding this comment.
How? We don't have common interface for service classes
There was a problem hiding this comment.
How?
We can do smth like this, but we'll have to do an unchecked cast later
Suggested change
| private val grpcRouter: GrpcRouter | |
| private val getService: (Class<out Any>) -> Any |
cordwelt
reviewed
Feb 8, 2023
| @@ -32,6 +33,7 @@ class HandlerContext( | |||
| private val channelFactory: ChannelFactory, | |||
| private val getDictionary: (DictionaryType) -> InputStream, | |||
| private val sendEvent: (Event) -> Unit, | |||
| private val grpcRouter: GrpcRouter | |||
There was a problem hiding this comment.
How?
We can do smth like this, but we'll have to do an unchecked cast later
Suggested change
| private val grpcRouter: GrpcRouter | |
| private val getService: (Class<out Any>) -> Any |
Co-authored-by: Ivan Druzhinin <[email protected]>
cordwelt
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.