Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained 'opener' dependency with 'open' to fix URLs not opening on WSL2 #52

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Replace unmaintained 'opener' dependency with 'open' to fix URLs not opening on WSL2 #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40a928
Replace unmaintained 'opener' dependency with 'open' to fix URLs not …
cascornelissen Jul 18, 2020
7b2660d
Pin open dependency to 7.0.4
cascornelissen Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"libnpmconfig": "1.2.1",
"lodash": "4.17.14",
"npm-check-updates": "4.0.3",
"opener": "1.5.1",
"open": "^7.0.4",
cascornelissen marked this conversation as resolved.
Show resolved Hide resolved
"pacote": "9.5.4",
"semver": "6.2.0",
"yargs": "13.3.0"
Expand Down
4 changes: 2 additions & 2 deletions src/commands/changelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import opener from 'opener';
import open from 'open';

import catchAsyncError from '../catchAsyncError';
import {findModuleChangelogUrl} from '../changelogUtils';
Expand All @@ -24,7 +24,7 @@ export const handler = catchAsyncError(async opts => {

if (changelogUrl) {
console.log(`Opening ${strong(changelogUrl)}...`);
opener(changelogUrl);
open(changelogUrl);
} else {
console.log(
"Sorry, we haven't found any changelog URL for this module.\n" +
Expand Down
6 changes: 3 additions & 3 deletions src/commands/check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {writeFileSync} from 'fs';

import _ from 'lodash';
import {flow, map, partition} from 'lodash/fp';
import opener from 'opener';
import open from 'open';
import semver from 'semver';
import detectIndent from 'detect-indent';
import ncu from 'npm-check-updates';
Expand Down Expand Up @@ -181,7 +181,7 @@ export const handler = catchAsyncError(async opts => {

if (changelogUrl) {
console.log(`Opening ${strong(changelogUrl)}...`);
opener(changelogUrl);
open(changelogUrl);
} else {
console.log(
`Sorry, we haven't found any changelog URL for ${strong(name)} module.\n` +
Expand All @@ -202,7 +202,7 @@ export const handler = catchAsyncError(async opts => {

if (homepage) {
console.log(`Opening ${strong(homepage)}...`);
opener(homepage);
open(homepage);
} else {
console.log(`Sorry, there is no info about homepage URL in the ${strong(name)}'s package.json`);
}
Expand Down