New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lyrics font size #753

Merged

th-ch merged 1 commit into th-ch:master from Araxeus:fix-lyrics-font-size

Jun 25, 2022

Collaborator

Araxeus commented Jun 16, 2022 •

edited

Loading

fix #752

Instead of just using a value relative to the width of the viewport -
Minimum size 14px/1.4rem, target size is relative to the biggest dimensions (width/height), and max is 30px/3rem


          fix lyrics font size

d7ac493

Collaborator Author

Araxeus commented Jun 16, 2022

might be better to use max instead of clamp here since the 30px/3rem max value isn't really useful?

th-ch approved these changes

View reviewed changes

th-ch merged commit 32a5597 into th-ch:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet