fix notifications showing thumbnail of last song #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of the delay in
await getImage()
in songInfo.js, if the video sends a pause/play event beforegetImage()
finishes, it will send callbacks with the new songInfo - but with the old songInfo.image + everything that comes after thatawait
in the codeand thats because
handleData()
function updates some of the songInfo, then tries to download the image which takes a few miliseconds. so if the callbacks from playPause are triggered meanwhile, it will have new data from before theawait getImage()
but not the rest since it wasn't updated yet.I hope this explanation was clear enough. if not then I can try explaining more clearly