Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsorblock fix + use new apiLoaded event #463

Merged
merged 6 commits into from
Nov 1, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Oct 30, 2021

  1. Update Electron to v12.2.2 - Fixes sponsor block not working
    image

note for near future: electron v14 remove the remote module
will need some code changes when v13 is deprecated at 25.03.2022
(electron v12 will be deprecated very soon - 16.11.2021)

  1. delete providers/video-element and use instead the new apiLoaded event in both disable-autoplay and sponsorblock plugins)

  2. Change all existing apiLoaded event listeners to close on trigger ({ once: true, passive: true })
    (api is loaded only once, page refresh re-register those listeners anyway)

  3. Fix spamming video time override d35fef8
    image

@Araxeus Araxeus changed the title Sponsorblock fix + use new videoloaded event Sponsorblock fix + use new apiLoaded event Oct 30, 2021
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix/improvements! ✅

@th-ch th-ch merged commit e765d18 into th-ch:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants