Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpris support with cherry picked commit from previous PR https://github.com/th-ch/youtube-music/pull/394 #395

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

itzmanish
Copy link
Contributor

@itzmanish itzmanish commented Sep 3, 2021

small PR only with mpris code changes took from th-ch:mpris branch.

@itzmanish itzmanish changed the title Add mpris support with cherry picked commit from previous PR Add mpris support with cherry picked commit from previous PR https://github.com/th-ch/youtube-music/pull/394 Sep 3, 2021
@itzmanish itzmanish mentioned this pull request Sep 3, 2021
@jrabinow
Copy link

jrabinow commented Sep 3, 2021

I've changed my linux setup since I opened the initial issue, so I can't test whether this will fix the issue I was seeing back then. But I'm sure this PR will help others.

Thank you for adding support for mpris!

@itzmanish
Copy link
Contributor Author

@th-ch your attention is needed here.

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it on Linux but diff looks good, thanks for the contribution! ✅

@th-ch th-ch merged commit 9cc320d into th-ch:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants