Fix discord clearActivity, menu, listen along option

[cpiber]

The callback sends multiple events, in particular two pause when going to the next song, so the timeout wasn't properly cleared. I have documented this.

Added menu buttons for the two options. Currently for the timeout time I simply open the config, to allow the user to properly input a number here a library is needed.

Now also clears activity directly if timeout enabled and set to 0.

[cpiber]

Currently we also don't handle (see #132 (reply in thread))

• Discord not running when starting (never connects)
• Discord closing (silently does nothing), does not reconnect

Supporting those would however require quite a bit of rewriting, is this in-scope? Should I do it?

[Araxeus]

• Discord not running when starting (never connects)
• Discord closing (silently does nothing), does not reconnect

It seems to me that it would require constant listening to other process / (which is too much IMO)
unless you have a nice and easy solution?

(I can't really find documentation about events at https://discord.js.org/#/docs/rpc/master/class/RPCClient)

[cpiber]

The RPC library emits a disconnected event

For the reconnecting, I would simply add a button to the menu, I agree that checking if discord is running periodically is too much

For the events, you kinda have to look through https://github.com/discordjs/RPC/blob/master/src/client.js, but most of the events are just carried on from discord itself

[Araxeus]

A button for reconnecting sounds neat 😎

[cpiber]

Currently, if the plugin fails to connect, there is no message to the user (neither on start nor on reconnect). Is this behaviour desirable or do you think an alert would be better?

[Araxeus]

Maybe show a message only when the reconnect button is clicked and it fails
(which would require some distinction between connect() and reconnect() or maybe just take an arg that indicate that its currently an initial connection or reconnect)

I don't think its necessary on startup, since you could easily start youtube-music with discord off - and it shouldn't be an error
(but if you explicitly click on reconnect button and no discord is active - seems like an error)

Great work btw :)

[avarayr]

@th-ch could you please review and merge?

[th-ch]

Did not fully test it, but diff looks good, thanks for the contribution! ✅

[Araxeus]

@cpiber Could you please explain the thinking process behind this export?

youtube-music/plugins/discord/back.js

Line 151 in f2e04f9

module.exports.info = Object.defineProperties({}, Object.keys(info).reduce((o, k) => ({ ...o, [k]: { enumerable: true, get: () => info[k] } }), {}));

why can't you just export something like

module.exports.isConnected = () => info.rpc !== null

[cpiber]

why can't you just export something like

I had it differently before (used more from info), of course that's way cleaner now 😅

[Araxeus]

Could you open a small pr to clean this up? if you're busy I can do it np

[cpiber]

Will do ^^