feat(tray): add support for tray icon themes #2809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new tray icons: `pause.png` and `play.png`. - Removed outdated icons: `youtube-music-tray.png` and `youtube-music-tray-paused.png`. - Enhances clarity and consistency of tray icon states.
- Replaced the YouTube Music tray icon with a new play icon. - Ensures alignment with updated asset paths for consistency.
- Fixed wrong icon showing for different player states. - Simplified tray icon setup by consolidating logic into reusable functions. - Replaced vague tray icon assets with clear play/pause icons for better clarity. - Improved code readability and maintainability by introducing helper functions and removing redundant code.
JellyBrick
requested changes
Dec 31, 2024
- Introduced `TrayIconTheme` with options: Default, Fluent, and Material. - Updated the tray menu and configuration to allow selecting tray icon themes. - Refactored tray icon handling to dynamically load icons based on selected theme.
- Replaced inline songInfo type with the existing SongInfo interface.
yilmazcabuk
changed the title
- Added the IconSet interface to group play and pause icons. - Replaced `createTrayIcons` with `createTrayIconSet` for better readability and maintainability. - Adjusted functions to leverage IconSet, simplifying code and improving parameter handling.
- Encapsulated tray-related logic into smaller, focused functions. - Introduced `AppContext` and `SongControls` interfaces for better structure. - Centralized tray icon size into a constant. - Simplified window visibility toggling with helper functions. - Improved tooltip and menu configuration clarity.
- Replaced repetitive type prefixes with imported Electron types. - Combined `hideWindowAndDock` and `showWindowAndDock` into a unified function. - Modularized tray setup by separating icon creation and menu creation logic. - Improved function readability by restructuring and renaming where needed.
- Fixed `setUpTray` function calls to use an object argument `{ app, win }` for consistent structure.
- Updated all relevant occurrences in `index.ts` and `menu.ts`.
Refactored `updateTrayTooltip` to destructure `isPaused` directly from `songInfo` for cleaner and more consistent logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
refactor(tray): improved tray icon setup and handling.
refactor: update tray icon.
refactor(assets): updated tray icons.
pause.pngandplay.png.youtube-music-tray.pngandyoutube-music-tray-paused.png.Related Issues:
Changes:
Testing: