Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): Add repeat mode and seek time API #2630

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

sent44
Copy link
Contributor

@sent44 sent44 commented Nov 23, 2024

I hate Javascript and its family now.

I do not define any type structures (and dont want to do it; dont know where to put it)
Just push this in my folk or do review comment thing idk and I will add it to PR. Same thing with the code order or rename something.

close #2504
maybe not close but good to know #2582

@JellyBrick JellyBrick added the enhancement New feature or request label Nov 24, 2024
@JellyBrick
Copy link
Collaborator

Due to my personal circumstances, I can't review this PR before December 23. Sorry 🥲

@JellyBrick JellyBrick requested a review from Su-Yong December 5, 2024 13:42
@JellyBrick JellyBrick changed the title Add repeat mode and seek time API feat(api-server): Add repeat mode and seek time API Dec 24, 2024
@JellyBrick JellyBrick merged commit 109e9f8 into th-ch:master Dec 24, 2024
5 checks passed
@JellyBrick
Copy link
Collaborator

Thanks!

@sent44
Copy link
Contributor Author

sent44 commented Dec 25, 2024

Hello @JellyBrick ,
Thank you for the merged.
I understand the change in API, it is my bad because I never know it is already exist.
Did you accident nuke some of the seek-time code or did you planned to not merge this feature? Since you completely remove it in #544b9e3 in another PR. (On phone, I cannot really fetch the name of PR and cannot remember its name)

@JellyBrick
Copy link
Collaborator

@sent44 The seek-time code does the same thing as song-info so you can use /api/v1/song-info instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] (API Server): GET api/v1/switch-repeat-mode
2 participants