fix playPause bugs by directly playPause video element #259
Conversation
providers/song-controls-front.js
Outdated
| if (videoStream.paused) { | ||
| videoStream.play(); | ||
| } else { | ||
| videoStream.yns_pause(); |
There was a problem hiding this comment.
Uncaught TypeError: videoStream.yns_pause is not a function shouldn't it be
| videoStream.yns_pause(); | |
| videoStream.pause(); |
?
There was a problem hiding this comment.
Thats weird... where did you get that error?
pause() doesn't work on the youtube video stream.
yns_pause() is a function that I extracted from the actual youtube video stream and it works in all my tests
I didn't test it with auto-confirm-when-paused, we'll have to see what to do about that
maybe use this new ipc("playPause") only if auto-confirm-when-paused isn't enabled
and else use spacebar as before. but then it wont fix this issue for users that have that plugin enabled :(
There was a problem hiding this comment.
Maybe it depends on the platform 🤔 -> A workaround can be to check if yns_pause is an existing function, in which case it can be called, otherwise call pause.
Agreed about using it only if auto-confirm-when-paused isn't enabled, it's not perfect but this way it won't break stuff!
There was a problem hiding this comment.
I just realized 2 things:
auto-confirm-when-pausedwas enabled for me all along while testingpause()works only when YoutubeNonStop isn't active (because YoutubeNonStop overrides the original function)
yns_pause()is the originalpause()function that YoutubeNonStop saved and registered
source: YoutubeNonStop.overrideVideoPause()
With the latest changes, it should all work flawlessly for you right?
this PR makes song-controls.playPause() affect directly the video element in the page. (instead of just pressing space)
This fixes several bugs when pausing the video when it isn't focused
(from tray/taskbar/notifications)
fix #145 , fix #129
also sneaky change because of previous comments:
song-info-front is directly required instead of checking if file exist (since we already know it exist)