Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precise volume listener override #253

Merged
merged 4 commits into from
May 6, 2021
Merged

Fix precise volume listener override #253

merged 4 commits into from
May 6, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented May 6, 2021 •
edited
Loading

Primarily fix youtube-music search bar not registering keyboard inputs.

probably also fix some other interactions

  • Arrow shortcuts no longer preventDefault() on every key press
  • Overridden Listeners wait for this.id to be "volume-slider" || "expand-volume-slider"

fix #256

@Araxeus Araxeus mentioned this pull request May 6, 2021
Closed
th-ch
th-ch approved these changes May 6, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, thanks for the fix! ✅

@th-ch th-ch merged commit d1795a8 into th-ch:master May 6, 2021
@Araxeus Araxeus deleted the fix-precise-volume-listener-override branch May 8, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot type out words on the search bar
2 participants
@Araxeus @th-ch