New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloader metadata #245

Merged

th-ch merged 3 commits into master from fix-downloader-metadata

Apr 29, 2021

Owner

th-ch commented Apr 29, 2021

This PR improves/fixes the downloader plugin:

fix URL to download (cases where a / was missing, leading to an invalid URL - worst case, a double slash should not be an issue)
set max file name length to 255 (was 100 previously)
set metadata in the main process (allowing to set a cover) - current metadata is still used to have up-to-date info (only drawback, the cover is not up-to-date if the song was changed but should not be a big deal)

th-ch added 3 commits

April 29, 2021 22:56


          Fix download URL

8a5c39e


          Set max file length to 255 in downloader

c11ecd3


          Set metadata in back (to have cover)

dfbda7c

th-ch merged commit a406ba4 into master

th-ch deleted the fix-downloader-metadata branch

April 29, 2021 21:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet