New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scrobblers): use `BrowserWindow` instead of `shell.openExternal` #1758

Merged

JellyBrick merged 2 commits into master from fix/lastfm-scrobbler-popup

Feb 20, 2024

Collaborator

JellyBrick commented Feb 19, 2024 •

edited

Loading

last.fm Desktop API doesn't support callbacks, so we need to use this method.

close [Bug]: last.fm scrobbler settings migration failure #1756


          feat: use BrowserWindow instead of shell.openExternal

860c01a

JellyBrick added the enhancement label

JellyBrick self-assigned this

JellyBrick mentioned this pull request

[Bug]: last.fm scrobbler settings migration failure #1756

Closed

5 tasks


          fix: duplicated popup

a182abc

JellyBrick merged commit 5178cc6 into master

8 checks passed

JellyBrick deleted the fix/lastfm-scrobbler-popup branch

February 20, 2024 02:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels