Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security issues in dependencies #1116

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Apr 15, 2023

aims to fix all the issues in https://github.com/th-ch/youtube-music/security/dependabot

image

  • minimatch 3.0.4 is in @electron/universal:
    electron-builder@npm:23.6.0 (via npm:^23.6.0)
    ├─ app-builder-lib@npm:23.6.0 (via npm:23.6.0)
    ├─ @electron/universal@npm:1.2.1 (via npm:1.2.1)
    ├─ asar@npm:3.2.0 (via npm:^3.1.0)
    │ ├─ glob@npm:7.2.3 (via npm:^7.1.6)
    │ └─ minimatch@npm:3.1.2 (via npm:^3.0.4)
    ├─ dir-compare@npm:2.4.0 (via npm:^2.4.0)
    │ └─ minimatch@npm:3.0.4 (via npm:3.0.4)
    └─ minimatch@npm:3.1.2 (via npm:^3.0.4)

  • yargs-parser 4.2.1 is in electron-icon-builder
    electron-icon-builder@npm:2.0.1 (via npm:^2.0.1)
    └─ icon-gen@npm:2.1.0 (via npm:^2.0.0)
    └─ svg2png@npm:4.1.1 (via npm:4.1.1)
    └─ yargs@npm:6.6.0 (via npm:^6.5.0)
    └─ yargs-parser@npm:4.2.1 (via npm:^4.2.0)

  • request 2.88.2 is in electron-icon-builder
    electron-icon-builder@npm:2.0.1 (via npm:^2.0.1)
    └─ icon-gen@npm:2.1.0 (via npm:^2.0.0)
    └─ svg2png@npm:4.1.1 (via npm:4.1.1)
    └─ phantomjs-prebuilt@npm:2.1.16 (via npm:^2.1.14)
    └─ request@npm:2.88.2 (via npm:^2.81.0)

  • svg2png 4.1.1 is in electron-icon-builder
    electron-icon-builder@npm:2.0.1 (via npm:^2.0.1)
    └─ icon-gen@npm:2.1.0 (via npm:^2.0.0)
    └─ svg2png@npm:4.1.1 (via npm:4.1.1)

  • xml2js is in mpris-service and electron-icon-builder

Note
If you look closely you'll notice that most of those are because of electron-icon-builder

@Araxeus Araxeus changed the title fix security issues in deps fix security issues in dependencies Apr 15, 2023
@Araxeus Araxeus mentioned this pull request Apr 15, 2023
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about icon generation

package.json Outdated Show resolved Hide resolved
@Araxeus Araxeus mentioned this pull request Apr 15, 2023
@Araxeus Araxeus force-pushed the fix-security-issues-in-deps branch from e9cc7ec to 9cde19d Compare April 15, 2023 20:56
@th-ch th-ch merged commit 040946c into th-ch:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants