Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Rich Presence doesn't auto update #504

Closed
AdamPype opened this issue Dec 1, 2021 · 12 comments
Closed

Discord Rich Presence doesn't auto update #504

AdamPype opened this issue Dec 1, 2021 · 12 comments
Labels
fix-available A fix to the issue is available in a new version

Comments

@AdamPype
Copy link

AdamPype commented Dec 1, 2021

For some reason, the Discord Rich Presence gets stuck on whatever song it was playing before when it starts playing a new song. If I manually press the next song button on Youtube Music or select a song then it updates, otherwise, it doesn't.

Any ideas about what might be causing this?

For example:
image
image

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 1, 2021

#477 should have fixed this

New app version including said fix will be released soon ^_^

@AdamPype
Copy link
Author

AdamPype commented Dec 1, 2021

yay! that's great news! thank you so much for the reply!

@DereC4
Copy link
Contributor

DereC4 commented Dec 3, 2021

thx

@NuclearMeltdown
Copy link

Will this also fix notifications not showing up and the tuna plugin not updating unless songs are skipped, or is that a different issue?

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 21, 2021

Will this also fix notifications not showing up and the tuna plugin not updating unless songs are skipped, or is that a different issue?

@NuclearMeltdown yes it should be the same problem which was already fixed in earlier PR's. (#473 #477)

Now just waiting for a new version to be released that includes those latest changes

@mesmerx
Copy link
Contributor

mesmerx commented Dec 22, 2021

the fix should be in the lastest release :)

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 22, 2021

the fix should be in the lastest release :)

no its not. new version wasn't released yet... unless you wrote this in the future? O_o

(#477 was merged on Nov 30, 2021 and last version was released in Nov 09, 2021)

@NuclearMeltdown
Copy link

NuclearMeltdown commented Dec 23, 2021

yes it should be the same problem which was already fixed in earlier PR's. (#473 #477) Now just waiting for a new version to be released that includes those latest changes

@Araxeus I built the app from source and the main issues do seem to be fixed. The only thing I noticed is that the 'time left' value in the Discord rich presence doesn't update properly. When the next song in an album or playlist starts, the counter is always off from what it should be. For example, when the next song starts and it's 4 minutes long, right after starting, the rich presence shows a minute left, or just 0:00. If it's stuck at 0:00, it mostly won't go back up at all when a new song starts. It works fine when manually starting or skipping a song. In some rarer cases, the counter doesn't react to skipping forwards or backwards in a song or pausing at all, just song change events. In this case, the counter is stuck counting down from whatever value it had from the start of the song. Though I haven't found a way to reproduce it yet, it's fixed by restarting the app. I know that what I tested isn't an official release, but I just wanted to give a heads up that in the current state of the code, not everything is fixed, even though it's a rather minor issue.

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 23, 2021

@NuclearMeltdown thank you for the details, much appreciated

Sadly i've already encountered this bug but honestly have no idea whats causing it
(I think it might be a bug with the discord library since from my testing, the time value that we pass to discord is correct)

@NuclearMeltdown
Copy link

Yeah, I just noticed that it works perfectly fine in that other, for some reason more popular YTM wrapper. But I refuse to use it because it uses so many more resources for the same or even less functionality.

@mesmerx
Copy link
Contributor

mesmerx commented Dec 23, 2021

the fix should be in the lastest release :)

no its not. new version wasn't released yet... unless you wrote this in the future? O_o

(#477 was merged on Nov 30, 2021 and last version was released in Nov 09, 2021)

oh sorry i loses myself a little with releases

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 3, 2022

@JellyBrick JellyBrick added the fix-available A fix to the issue is available in a new version label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Development

No branches or pull requests

6 participants