Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app doesn't update music info correctly when music is not skipped. #473

Closed
saltyming opened this issue Nov 9, 2021 · 4 comments · Fixed by #477
Closed

The app doesn't update music info correctly when music is not skipped. #473

saltyming opened this issue Nov 9, 2021 · 4 comments · Fixed by #477

Comments

@saltyming
Copy link

saltyming commented Nov 9, 2021

Issue

App doesn't update the music info when the next music begins automatically. It breaks notification, discord, and pretty other stuffs that depend on it.

Environment

Gnome 40.5, Arch Linux
youtube-music-bin 1.14.0-1

How to reproduce

  1. Play a music (playlist) and leave the app alone.
  2. See whether app sends notification when the next music begins.

How not to reproduce

  1. Play the next music manually.
@saltyming saltyming changed the title The app doesn't send notifications correctly when music is not skipped. The app doesn't send music info correctly when music is not skipped. Nov 9, 2021
@saltyming saltyming changed the title The app doesn't send music info correctly when music is not skipped. The app doesn't update music info correctly when music is not skipped. Nov 9, 2021
@Araxeus
Copy link
Collaborator

Araxeus commented Nov 9, 2021

Works perfectly fine for me, could you check that you are indeed using the last version?
are you using the adblocker?

This actually doesn't make much sense, I don't see any difference between "manual" or "automatic" track switching.
the music info is updated whenever the current metadata is updated (which happens when the app loads a track)

document.querySelector('video').addEventListener('loadedmetadata', () => {

Also I find it weird that you are the only one to complain about this seemingly app breaking bug

@saltyming
Copy link
Author

saltyming commented Nov 9, 2021

Works perfectly fine for me, could you check that you are indeed using the last version?

This actually doesn't make much sense, I don't see any difference between "manual" or "automatic" track switching. the music info callback is called whenever the metadata is updated:

document.querySelector('video').addEventListener('loadedmetadata', () => {

and also I find it very weird that only you complained about this app breaking bug

Video verification
Yes, I'm running latest AUR version; youtube-music-bin 1.14.0-1
Please do not think I like complaining and tackling :)

Edited: I also tried to set high notification priority but it doesn't work.
Edited 2: I can't see anything wrong in journalctl except 'Buffer() is deprecated' warning.

@bytang
Copy link

bytang commented Nov 9, 2021

I think I am experiencing the same behaviour. I am running 1.14 on Windows and I see this behaviour in Last.fm scrobbling.

image

It scrobbles the same song 3 times while the playlist goes through three different songs. If I skip to next song, it scrobbles the new song as intended (not shown in screenshot).

I use last-fm and navigation plugins. I tried a clean reinstall and it is the same behaviour.

@Araxeus
Copy link
Collaborator

Araxeus commented Nov 9, 2021

@bytang thank you for confirming this issue. i've been working on it and testing with the help of @FiestaLake and after many hours and tries we have found a fix.

PR #477 implement said fix and will hopefully be soon merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants