Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Genius lyrics incorrect #1050

Closed
Zo-Bro-23 opened this issue Mar 1, 2023 · 13 comments · Fixed by #1052
Closed

[Bug]: Genius lyrics incorrect #1050

Zo-Bro-23 opened this issue Mar 1, 2023 · 13 comments · Fixed by #1052

Comments

@Zo-Bro-23
Copy link
Contributor

The genius lyrics are incorrect for most malayalam songs.

image

Any malayalam song that doesn't have genius lyrics ends up showing the lyrics for Thee Minnal. Any idea why this is? The incorrect lyrics always show this same set of lyrics, although that has nothing to do with the song I'm listening to. Is it anything to do with the Genius query algorithm?
@LoggeL
Copy link

LoggeL commented Mar 1, 2023

Did you validate that genius shows the correct lyrics on their site?

@Zo-Bro-23
Copy link
Contributor Author

Genius doesn't have lyrics on their site for these songs.

@Araxeus
Copy link
Collaborator

Araxeus commented Mar 2, 2023 •
edited
Loading

Can you give more examples?

I tried loading this song, and the lyrics tab was disabled

EDIT: NVM I got it to bug out, check this out:

https://genius.com/api/search/multi?per_page=5&q=Sushin%20Shyam%20&%20Pradeep%20Kumar%20Ottamuri%20Vakkumayi

@Araxeus
Copy link
Collaborator

Araxeus commented Mar 2, 2023 •
edited
Loading

I think this is a bug with genius search, because how does that query string have these results? 🧐

It looks like since the artist name includes &, it's making the search find unrelated stuff since it's ending the q= param

@Araxeus
Copy link
Collaborator

Araxeus commented Mar 2, 2023

The URL I posted above yields the same results as https://genius.com/api/search/multi?per_page=5&q=Sushin%20Shyam

Which confirms my theory that including & in the query is a very bad idea

Araxeus added a commit to Araxeus/youtube-music that referenced this issue Mar 2, 2023
@Araxeus
fix unescaped url params
9ff4061 
fix th-ch#1050
@Araxeus Araxeus mentioned this issue Mar 2, 2023
Merged
@Araxeus
Copy link
Collaborator

Araxeus commented Mar 2, 2023

I've opened a PR which should fix this (#1052), could you test it?

@Zo-Bro-23
Copy link
Contributor Author

Thanks for the PR! I would love to test it out, but since I'm working on a plugin at the moment, I can't have multiple instances running. I'm testing that version out right now. @DereC4 can you try this out please? Thanks!

@DereC4
Copy link
Contributor

DereC4 commented Mar 3, 2023

I will after I'm done with this assembly lab 😭

@DereC4
Copy link
Contributor

DereC4 commented Mar 3, 2023

Can you name me some song names to test?

@Zo-Bro-23
Copy link
Contributor Author

Can you name me some song names to test?

Athmave Poo, Ottamuri Vakkumayi, and Thalatherichvar. Try both video and audio versions. Also try other songs by Sushin Shyam. Thanks for doing this!

@DereC4
Copy link
Contributor

DereC4 commented Mar 3, 2023

Doesn't seem to put the wrong lyrics anymore at least

@Zo-Bro-23
Copy link
Contributor Author

image

Not working on the latest commit.

@Araxeus
Copy link
Collaborator

Araxeus commented Apr 3, 2023

Not working on the latest commit.

Should work now on main since #1090 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lyrics-genius] Fix lyrics not showing up or showing up when they shouldn't Araxeus/youtube-music
4 participants
@LoggeL @DereC4 @Zo-Bro-23 @Araxeus