Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server tools API v3.1 #31000

Merged
merged 58 commits into from
Sep 29, 2017
Merged

Server tools API v3.1 #31000

merged 58 commits into from
Sep 29, 2017

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Sep 24, 2017 •
edited
Loading

To go hand in hand with TGS 3.1

  • /datum/chat_command for creating commands from in-game
  • No more broken relays
  • Moves new game announcement to after initializations are complete
  • Removes HttpsGet
  • Procs for getting the service version and API version

Cyberboss added 30 commits July 27, 2017 11:41
@Cyberboss
New API for service communication
15f0ece
@Cyberboss
Safer this way
6638d3a
@Cyberboss
Gives the game the ability to kill itself
dba5f49
@Cyberboss
tick_lag
17426cf
@Cyberboss
Sanity check
1db557a
@Cyberboss
Updates comment
5c9a3f9
@Cyberboss
Formalization of the server tools API
5cb14db
@Cyberboss
Fixes, finishes, and cleanup
ef2d1b4
@Cyberboss
Remove unecessary scoping
099e3e7
@Cyberboss
Compile fixes
72e178f
@Cyberboss
Didn't Ctrl+S
e258852
@Cyberboss
Reimplement chat commands
10892e5
@Cyberboss
Fixup
df0eb9f
@Cyberboss
Required parameters
f3d05f2
@Cyberboss
Fax
b47e512
@Cyberboss
Testing
3fdb36c
@Cyberboss
Fix ON_TOPIC
75a38f2
@Cyberboss
The more defines the more better
3e127c0
@Cyberboss
That's bass ackwards
7a038e8
@Cyberboss
Fix tgs2
fc81381
@Cyberboss
Merge branch 'master' into SecureServerTools
32849a2
@Cyberboss
Fuck it, call him pichael
3cce12a
@Cyberboss
Do this
3ae961f
@Cyberboss
Merge remote-tracking branch 'origin/SecureServerTools'
4176551
@Cyberboss
Merge remote-tracking branch 'origin/BetterShutdown'
b654012
@Cyberboss
Merge the official API
42c2d6e
@Cyberboss
No, we only use the modern methods now
b156ad0
@Cyberboss
Remove tgs2 relay support
e5d1960
@Cyberboss
Remove kebab
11839af
@Cyberboss
Kill kill kill
e44a04e
@tgstation-server tgstation-server added the Config Update Time to bother the headadmins for three months to get your config applied label Sep 24, 2017
@Cyberboss Cyberboss added the Do Not Merge You must have really upset someone label Sep 24, 2017
@Iamgoofball
Copy link
Contributor

#31000

@Cyberboss
Copy link
Member Author

Omfg i didn't even try

Cyberboss
Cyberboss commented Sep 24, 2017
View reviewed changes
code/modules/admin/chat_commands.dm Outdated

/datum/server_tools_command/notify
name = "notify"
help_text = "Pings the invoker when the running round ends"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shadowlight213 you wanted this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nbot already has this. I just need to change the trigger wording a bit to fix it.
Mso wanted something different where the notify would work even if the relay/bots went down, which I know how to do but haven't gotten around to due to various reasons. Adding this to the server tools leaves it at the mercy of the relay working, which doesn't really do what mso wanted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relays never break with the new version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy. Screenshotting this for when they do.
Anyways still doesn't do what mso wanted, and is kinda redundant.

@Cyberboss Cyberboss added Do Not Merge You must have really upset someone and removed Do Not Merge You must have really upset someone labels Sep 24, 2017
@Cyberboss Cyberboss removed the Do Not Merge You must have really upset someone label Sep 27, 2017
@Iamgoofball
Copy link
Contributor

@Cyberboss generate credits with the server tools when updating from git

just do it

@Cyberboss
Copy link
Member Author

Cyberboss commented Sep 27, 2017 •
edited
Loading

It's not something to be hard coded into the server tools, I have another plan for it using @JamieH's preaction framework, but I need us to be running the latest version first

@Iamgoofball
Copy link
Contributor

ok

@Cyberboss Cyberboss added the FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former label Sep 29, 2017
@optimumtact optimumtact merged commit 62f788f into master Sep 29, 2017
@ghost ghost mentioned this pull request Sep 29, 2017
Closed
@FTL13-Bot FTL13-Bot mentioned this pull request Sep 29, 2017
Closed
@Cyberboss Cyberboss deleted the ServerToolsAPIv31 branch September 29, 2017 03:20
@CitadelStationBot CitadelStationBot mentioned this pull request Sep 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowlight213 Shadowlight213 Shadowlight213 left review comments

Assignees
No one assigned
Labels
Config Update Time to bother the headadmins for three months to get your config applied FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cyberboss @Iamgoofball @Shadowlight213 @optimumtact @tgstation-server