Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s] v6.12.3: Why are we still here? Just to suffer?? #2065

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Jan 4, 2025

THIS IS WHY I DON'T FUCKING TOUCH THE AUTH PIPELINE

🆑
Fixed incorrect evaluation of user rights.
/🆑

Fixes #2064

@Cyberboss Cyberboss added Fix Fixes incorrect functionality Priority: CRITICAL Alarm clock up. Fix immediately Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) Release This is a release pull request Regression Test We've seen this before, make sure it doesn't happen again labels Jan 4, 2025
@Cyberboss Cyberboss added this to the v6.12.3 milestone Jan 4, 2025
@Cyberboss Cyberboss enabled auto-merge January 4, 2025 00:03
@Cyberboss Cyberboss linked an issue Jan 4, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@4a89ff5). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2065   +/-   ##
=========================================
  Coverage          ?   95.63%           
=========================================
  Files             ?      811           
  Lines             ?   175253           
  Branches          ?     3555           
=========================================
  Hits              ?   167597           
  Misses            ?     7086           
  Partials          ?      570           

@Cyberboss Cyberboss merged commit 7d7a3ac into master Jan 4, 2025
86 of 88 checks passed
@Cyberboss Cyberboss deleted the 2064-FUCK branch January 4, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes incorrect functionality Priority: CRITICAL Alarm clock up. Fix immediately Regression Test We've seen this before, make sure it doesn't happen again Release This is a release pull request Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can still read /Repository even when RepositoryRights.Read is unset
1 participant