Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS order announcements/hivemind #16662

Closed
wants to merge 6 commits into from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Oct 12, 2024

About The Pull Request

As the title says orders and xeno hivemind now use tts
TM because local testing doesnt exist

Why It's Good For The Game

Orders because its orders so nice to add more emphasis, hivemind because its the major comms venue for xenos

Changelog

🆑
add: hivemind now uses tts
add: orders now use tts
/:cl:

@tgstation-server tgstation-server added the Feature New interesting mechanics with new interesting bugs label Oct 12, 2024
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 14, 2024
comfyorange added a commit that referenced this pull request Oct 14, 2024
var/list/extra_filters = list(TTS_FILTER_RADIO)
if(isrobot(sender))
extra_filters += TTS_FILTER_SILICON
INVOKE_ASYNC(SStts, TYPE_PROC_REF(/datum/controller/subsystem/tts, queue_tts_message), marines_list, treated_message["tts_message"], sender.get_default_language(), sender.voice, sender.voice_filter, local = TRUE, pitch = sender.pitch, special_filters = extra_filters.Join("|"), directionality = FALSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marines_list should be the listeners arg, first arg is 'target' which seems to be the actual speaker. Same with the xeno annoucements

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2024
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2024
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2024
comfyorange added a commit that referenced this pull request Oct 15, 2024
comfyorange added a commit that referenced this pull request Oct 16, 2024
comfyorange added a commit that referenced this pull request Oct 16, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 18, 2024
comfyorange added a commit that referenced this pull request Oct 19, 2024
comfyorange added a commit that referenced this pull request Oct 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 23, 2024
comfyorange added a commit that referenced this pull request Oct 26, 2024
comfyorange added a commit that referenced this pull request Oct 28, 2024
comfyorange added a commit that referenced this pull request Oct 28, 2024
comfyorange added a commit that referenced this pull request Oct 29, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 31, 2024
@Lumipharon Lumipharon removed the Stale Pull request is awaiting delayed author response and may be closed. label Nov 1, 2024
comfyorange added a commit that referenced this pull request Nov 2, 2024
comfyorange added a commit that referenced this pull request Nov 7, 2024
comfyorange added a commit that referenced this pull request Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 9, 2024
comfyorange added a commit that referenced this pull request Nov 9, 2024
comfyorange added a commit that referenced this pull request Nov 11, 2024
@github-actions github-actions bot closed this Nov 12, 2024
comfyorange added a commit that referenced this pull request Nov 14, 2024
comfyorange added a commit that referenced this pull request Nov 15, 2024
comfyorange added a commit that referenced this pull request Nov 22, 2024
comfyorange added a commit that referenced this pull request Nov 22, 2024
comfyorange added a commit that referenced this pull request Nov 24, 2024
comfyorange added a commit that referenced this pull request Nov 24, 2024
comfyorange added a commit that referenced this pull request Nov 26, 2024
comfyorange added a commit that referenced this pull request Nov 27, 2024
comfyorange added a commit that referenced this pull request Dec 6, 2024
comfyorange added a commit that referenced this pull request Dec 8, 2024
comfyorange added a commit that referenced this pull request Dec 10, 2024
comfyorange added a commit that referenced this pull request Dec 12, 2024
comfyorange added a commit that referenced this pull request Dec 12, 2024
comfyorange added a commit that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Stale Pull request is awaiting delayed author response and may be closed. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants