Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LV 759 Cleaning and Caves Improvement #16464

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

Isy232
Copy link
Contributor

@Isy232 Isy232 commented Aug 13, 2024

About The Pull Request

Makes a lot of changes to LV 759, notable examples:

  • Redo of most of LV 759's caves keeping most of the original layout the same while attempting to make the open paths more clear.
  • Extreme reduction in the number of "bulbous rock"' tiles that looked a lot like impassable rock.
  • Removal of metal barriers in the middle of the road ways that made the roads very annoying for marine vehicles.
  • Change to area designations to get rid of the problem with out of bounds areas being accessible.
  • Reduction of cars on the roads in most areas to make the roads somewhat more clear.
  • Removal of hundreds of platform corners that were not removed along with the full sized platforms.

Other changes were probably spoken about in #mapping, it is difficult to list them all due to the nature of this.

Why It's Good For The Game

LV 759 Is a map I quite like for the colony part, however the caves have been criticized at length for being difficult to understand which tiles block movement and which do not.
The other major complaint was that vehicles were massively impeded by all the clutter on the roads.

I've modified the map to address these 2 primary concerns along with a few other smaller ones.

Changelog

🆑
qol: Various improvements to LV 759 particularly aimed at the caves and roadway clutter.
/:cl:

@tgstation-server tgstation-server added Map Edit One or more changes to .dmm files. Quality of Life Minor changes that make the game nicer to play labels Aug 13, 2024
@ivanmixo ivanmixo requested a review from RipGrayson August 18, 2024 16:47
@RipGrayson RipGrayson added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Aug 19, 2024
comfyorange added a commit that referenced this pull request Aug 24, 2024
comfyorange added a commit that referenced this pull request Aug 25, 2024
@DrAmazing343
Copy link

god bless, I've come around on LV759 a lot since the many improvements have been made, but it's still a map that's got kinks to work out. Kudos for chipping away at 'em!

comfyorange added a commit that referenced this pull request Aug 26, 2024
@Isy232
Copy link
Contributor Author

Isy232 commented Aug 27, 2024

image
From one of the times the PR was TM'ed, I will be removing those bugged platforms

comfyorange added a commit that referenced this pull request Aug 28, 2024
comfyorange added a commit that referenced this pull request Sep 1, 2024
comfyorange added a commit that referenced this pull request Sep 1, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Sep 2, 2024
@Isy232
Copy link
Contributor Author

Isy232 commented Sep 3, 2024

PR Should be ready to merge, I've addressed the points Grayson wanted me to and this PR has been TM'ed for some time.

comfyorange added a commit that referenced this pull request Sep 3, 2024
@RipGrayson RipGrayson added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Sep 6, 2024
comfyorange added a commit that referenced this pull request Sep 8, 2024
comfyorange added a commit that referenced this pull request Sep 9, 2024
comfyorange added a commit that referenced this pull request Sep 10, 2024
comfyorange added a commit that referenced this pull request Sep 10, 2024
comfyorange added a commit that referenced this pull request Sep 12, 2024
comfyorange added a commit that referenced this pull request Sep 13, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Sep 14, 2024
@RipGrayson RipGrayson merged commit 4dbbb48 into tgstation:master Sep 14, 2024
36 checks passed
github-actions bot added a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Edit One or more changes to .dmm files. Quality of Life Minor changes that make the game nicer to play Stale Pull request is awaiting delayed author response and may be closed. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants