Change base URL to use the HTTP Host header. #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the HTTP 'Host' header when available, to make sure the lineup is generated on whatever hostname the client contacted the server on. Fall back to the old logic if the 'Host' header is missing (possible on old\janky HTTP 1.0 clients, where it wasn't a required field). This should help resolve the confusion in setting addresses in configs.
|
Hello FozzieBear. The one thing I was concerned about was keeping the server is consistent with what is reported in SSDP responses. I have some psuedologic written in #98, let me know if this is an acceptable -- especially renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the HTTP 'Host' header when available, to make sure the lineup is generated on whatever hostname or IP the client contacted the server on. This should hopefully resolve\negate some of the confusion around setting addresses in configs. Been using this config in my local build for a while without issue; it's similar to the proposed method in #92, just adds a safety net fallback for clients that fail to include the HTTP Host header (old HTTP1.0 clients, or just straight non-compliant clients).