Update definedNames #686
Open
Update definedNames #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a bit of weird stuff in the spec I'm going to ignore as it doesn't appear to be implemented in other mature libraries
so printArea etc. This also fixes a number of tests.
includes tests
Modified the xlsx file to remove some metadata that Excel adds so that the round trip can get properly tested.
sheet_id is already a local var, don't overwrite it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined names are currently partially implemented (in regards to the spec and reading/writing). This PR should bring them more into line with the spec https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.revisiondefinedname?view=openxml-2.8.1