Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docstring or @extend_schema to create/update doesn't take any effect #338

Closed
krzysieqq opened this issue Mar 14, 2021 · 2 comments
Closed

Comments

@krzysieqq
Copy link

When I add any docstring or @extend_schema to the method like create or update in using APIViews it doesn't render in swagger UI. I think it could work the same as adding docstring or @extend_schema to post/put/patch methods. Am I doing something wrong or it is the intended behavior?

@tfranzel
Copy link
Owner

This works without an issue. However this has to be taken into consideration: https://drf-spectacular.readthedocs.io/en/latest/faq.html#using-extend-schema-on-apiview-has-no-effect

@tfranzel
Copy link
Owner

closing this issue for now. feel free to comment if anything is missing or not working and we will follow-up.

ngnpope added a commit to ngnpope/drf-spectacular that referenced this issue Sep 23, 2021
Ensure that only validation keywords and values that are suitable for
the detected type are used, e.g. `maximum` isn't valid for `type` of
`string`.

See the following links for details:

- https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-4
- https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.section.6

Closes tfranzel#338.
ngnpope added a commit to ngnpope/drf-spectacular that referenced this issue Sep 26, 2021
Ensure that only validation keywords and values that are suitable for
the detected type are used, e.g. `maximum` isn't valid for `type` of
`string`.

See the following links for details:

- https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-4
- https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.section.6

Closes tfranzel#338.
ngnpope added a commit to ngnpope/drf-spectacular that referenced this issue Sep 28, 2021
Ensure that only validation keywords and values that are suitable for
the detected type are used, e.g. `maximum` isn't valid for `type` of
`string`.

See the following links for details:

- https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-4
- https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.section.6

Closes tfranzel#338.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants