Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters no longer show their defaults #226

Closed
chaosk opened this issue Dec 7, 2020 · 5 comments
Closed

Parameters no longer show their defaults #226

chaosk opened this issue Dec 7, 2020 · 5 comments

Comments

@chaosk
Copy link
Contributor

chaosk commented Dec 7, 2020

Hello!

Starting with 0.9.14, all parameters ignore certain attributes, such as default. Previously this only affected path parameters (since they must be required, a default value doesn't make much sense).

Describing defaults for query params seems very useful to show how API behaves when not provided with a parameter value.

Would it be possible to bring back previous behavior, or at least make it easier to customize?

@tfranzel
Copy link
Owner

tfranzel commented Dec 8, 2020

hey @chaosk, there was no intended change there as far as i remember. i'll have to investigate.

@chaosk
Copy link
Contributor Author

chaosk commented Dec 8, 2020

From the looks of it, it was this change: 50eff74#diff-d727722caf6fe5f5507940c9efbcbe843fcca1dec9ac64402f074b08dd1c294fR250

@tfranzel
Copy link
Owner

tfranzel commented Dec 8, 2020

ahh thx, good catch. i'll try to remedy that.

@tfranzel
Copy link
Owner

tfranzel commented Dec 8, 2020

@chaosk the original behavior should be largely restored with that change.

@chaosk
Copy link
Contributor Author

chaosk commented Dec 8, 2020

Thank you for quick fix!

@chaosk chaosk closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants