Referece PREF64 #28
Merged
Referece PREF64 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashi
reviewed
Nov 1, 2023
Comment on lines
466
to
467
| {{!RFC7050}}, or by receiving a PREF64 Router Advertisement from the network {{!RFC8781}}. | ||
| It then synthesizes an appropriate IPv6 address (or |
There was a problem hiding this comment.
Suggested change
| {{!RFC7050}}, or by receiving a PREF64 Router Advertisement from the network {{!RFC8781}}. | |
| It then synthesizes an appropriate IPv6 address (or | |
| {{!RFC7050}}, or uses PREF64s {{!RFC8781}} received from the network | |
| to synthesize appropriate IPv6 addresses |
As RFC8781 mentioned there might be multiple prefixes.
There was a problem hiding this comment.
I tried to make it the same as the text for RFC7050 which also doesn't mention there being multiple prefixes but the "a" in the sentence is indeed misleading.
How about the below?
+ {{!RFC7050}}, or uses PREF64s received from Router Advertisements {{!RFC8781}}.There was a problem hiding this comment.
Looks good to me.
Nit-picking: Replacing "It" with "The device" might be a bit more explicit.
tfpauly
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
(Sorry I made the PR myself because I wanted my name in the blame.)