Update sorting algorithm with SVCB RRs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfpauly
requested changes
Oct 18, 2023
draft-happy-eyeballs-v3.md
Outdated
Comment on lines
283
to
284
| combination of properties will be referred to as the "First Address | ||
| Combination Count" and can be a configurable value. This avoids waiting |
There was a problem hiding this comment.
The summary a ways below has a definition for "First Address Family Count", so we would need to update all references to this.
And I'm not sure about the "Combination Count"... how about calling this:
"Preferred Protocol Attempt Count" or something??
There was a problem hiding this comment.
"Preferred Protocol Attempt Count" mentions protocol but doesn't really imply that it's a combination of protocols and address families. How about calling it something like "Preferred Protocol Combination Count" for now and we can always iterate on it? Or is the word "combination" not as preferable?
There was a problem hiding this comment.
Yeah "Preferred Protocol Combination Count" works for me
tfpauly
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2