Inline encoding stuff #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually just the |
Closed
Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago (#58) I split up modules into types, decoders, and encoders. Since then I've come to dislike this style. It makes it very hard to figure out exactly how a type is converted to and from binary and JSON without going to many different files.
One good thing to come out of that old PR was pushing JSON definitions closer to the types, rather than having one module that defines all the JSON instances. I'm going to keep that.
My goal for this PR is to completely remove the
Rattletrap.Decode.*andRattletrap.Encode.*modules, with the possible exception of*.Common.