Fix discovery with absolute paths #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Jun 29, 2024
| $ if null incs then ["**"] else incs | ||
| files <- Trans.lift $ MonadWalk.walk "." inclusions exclusions | ||
| files <- Trans.lift $ MonadWalk.walk root inclusions exclusions |
There was a problem hiding this comment.
The basic idea of this fix is that we'll use root rather than the current directory to search for files. The files returned are relative to the root, and the inclusions and exclusions are also evaluated relative to the root. So everything works out nicely without having to do too much.
Removing a lot of calls to combine root is a nice bonus.
tfausak
commented
Jun 29, 2024
source/test-suite/Main.hs
Outdated
| " N.M2" | ||
| ] | ||
| d <- Directory.getCurrentDirectory | ||
| Gild.mainWith ["--input", FilePath.combine d "i.cabal", "--output=r.cabal"] |
There was a problem hiding this comment.
I originally had a pure test for this, but I think it makes more sense to test using the real file system. Windows paths are weird, and using the actual filesystem exercises the functionality without jumping through a bunch of hoops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.