Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow discovering more fields #86

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Allow discovering more fields #86

merged 1 commit into from
Jun 19, 2024

Conversation

tfausak
Copy link
Owner

@tfausak tfausak commented Jun 19, 2024

Fixes #68.

Some of these fields could perhaps have more reasonable default inclusion filters. For example, c-sources could match only **/*.c and **/*.h by default. However it felt less surprising to simply discover any files in the given directories. I suspect that will work for most people. And if not, it's easy enough to throw a --include=... on there.

@tfausak
Copy link
Owner Author

tfausak commented Jun 19, 2024

I'm a little unhappy with how much information there is to convey about the discover pragma. It makes me think that maybe it should be an entirely separate tool. That way cabal-gild could focus on formatting while cabal-discover (or whatever) could handle this tricky file discovery stuff.

However at this point I don't think it would be worth it for me to create an entirely separate project. Also without exact printing, the discovery tool would be in a bit of a weird place.

@tfausak tfausak merged commit 99b2c6c into main Jun 19, 2024
10 checks passed
@tfausak tfausak deleted the gh-68-discover-more-fields branch June 19, 2024 14:54
@tfausak tfausak added the enhancement New feature or request label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow discovering more fields
1 participant