Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidation auctions can be created with no tez_to_auction #95

Closed
dorranh opened this issue Apr 23, 2021 · 1 comment · Fixed by #113
Closed

Liquidation auctions can be created with no tez_to_auction #95

dorranh opened this issue Apr 23, 2021 · 1 comment · Fixed by #113
Assignees

Comments

@dorranh
Copy link
Contributor

dorranh commented Apr 23, 2021

In cases where the input burrow has zero collateral, burrow_request_liquidation returns a liquidation_details with tez_to_auction=0mutez. This could potentially bog down/block the auction queue, so we should probably avoid generating the auction in these cases.

Somewhat related to #93 in that involves allowing calculations to handle burrows with zero collateral.

@gkaracha
Copy link
Contributor

Great catch! 👌 I think having tez_to_auction be zero is OK for burrow_request_liquidation. If anything, the liquidation request is successful. I think the cleanest solution to this is to handle the special case in entrypoint_mark_for_liquidation, where you'd skip all the updates to the liquidation auction if tez_to_auction = 0mutez.

@gkaracha gkaracha self-assigned this Apr 28, 2021
gkaracha added a commit that referenced this issue May 3, 2021
gkaracha added a commit that referenced this issue May 4, 2021
gkaracha added a commit that referenced this issue May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants