feat(rule): add "disabled" and "allows" for each dict item #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Jan 3, 2019
| @@ -251,13 +263,17 @@ module.exports = [ | |||
| }, | |||
| { | |||
| // https://azu.github.io/morpheme-match/?text=動作の(確認を行わなければ)ならない | |||
| id: "dict5", | |||
| disabled: false, | |||
| allows: ["/^[ァ-ヶ]+を.?行う/", "/^[a-zA-Z]+を.?行う/"], | |||
There was a problem hiding this comment.
デフォルト値をとりあえず カナカナと英語 は無視という大雑把なものを入れたけど、どうするべきかな
shirayu
reviewed
Jan 3, 2019
README.md
Outdated
| - 参考: <http://www.atmarkit.co.jp/ait/articles/1001/19/news106_2.html> | ||
| - "を行う"は冗長な表現です。"する"など簡潔な表現にすると文章が明瞭になります。 | ||
| - 【dict5】 "\[名詞]を行う"は冗長な表現です。"\[名詞]する"など簡潔な表現にすると文章が明瞭になります。 |
There was a problem hiding this comment.
「サ変名詞」と書くと普通の人はわからないと思うので、補足のリンクが必要そうですね。
There was a problem hiding this comment.
参考リンクを READMEへのリンクをして、各ルールごとに解説を書いていくスタイルにした方がいいかな。(リンク切れ対策も含めて
|
|
LGTM 👍 |
This was referenced Jan 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
各辞書に対してオプションを指定できるように
disabled- 辞書を無効化allows- 無視したいパターンを指定できる(〜を実行、〜を行う 向け)resolve #13