GetRecords improvement #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Dort-Golts <[email protected]>
Signed-off-by: Anton Dort-Golts <[email protected]>
dgtony
force-pushed
the
improvement/get-records-handler
branch
from
46254d8 to
3924e28
Compare
sanderpick
approved these changes
Dec 11, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if some node makes
GetRecordsrequest to another one, that hasn't received requested log offset yet, the latter responds with entire log (truncated at the limit). Here we propose an improvement: upon receiving a request, at first node should check if provided offset was already seen, otherwise it just returns empty log.