Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Text Format #778

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Removes Text Format #778

merged 2 commits into from
Aug 30, 2022

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Aug 30, 2022

Per tetratelabs/wabin#1, we've canceled the WebAssembly Text Format feature and moved it to another repository https://github.com/tetratelabs/watzero for resumption or archival.

First, I consolidated the code needed for watzero to work under internal/watzero. Then, I made a new repo like so:

git clone https://github.com/tetratelabs/wazero.git watzero
cd watzero/
git checkout watzero
git subtree split -P internal/watzero -b watzero-only
git checkout watzero-only
git remote add watzero https://github.com/tetratelabs/watzero.git
git push -f watzero watzero-only:main

Adrian Cole added 2 commits August 30, 2022 09:39
Signed-off-by: Adrian Cole <[email protected]>
rm
Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt marked this pull request as ready for review August 30, 2022 01:50
@codefromthecrypt
Copy link
Contributor Author

once this is in, I'll move the text format issues to https://github.com/tetratelabs/watzero

@mathetake
Copy link
Member

mathetake commented Aug 30, 2022

fyi as long as you have the go.mod package name as github.com/tetratelabs/wazero/internal/watzero, not github.com/tetratelabs/watzero in the tetratelabs/watzero repository, you can reference any internal structures

@codefromthecrypt
Copy link
Contributor Author

@mathetake roger. one intentional act here was exporting some types we otherwise kept hidden as there was a request to manipulate the binary forms. So, I think it is best to not make a dep back on wazero even if it implied some copy/pasta (a lot of it).

@codefromthecrypt codefromthecrypt merged commit 69863c4 into main Aug 30, 2022
@codefromthecrypt codefromthecrypt deleted the watzero branch August 30, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants