Change OperationSwap to OperationSet #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
commented
Aug 29, 2022
Comment on lines
-850
to
-851
| &OperationSwap{Depth: depth + 2, IsTargetVector: isVector}, | ||
| &OperationDrop{Depth: &InclusiveRange{Start: 0, End: 1}}, |
There was a problem hiding this comment.
OperationSwap was always followed by Drop, and because of that, we had a redundant register allocation in Swap. That is what this commit resolves.
codefromthecrypt
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
wazeroir.OperationSwaptoOperationSetwhich is thecombination of OperationSwap and Drop in the previous implementation.
Previously,
OperationSwapwas always followed byOperationDropon the swapped value on top.Because of that, we had a redundant register allocation in Swap.
As a result, we use only one register in
OperationSetwhich is a part of translations oflocal.teeandlocal.set.Signed-off-by: Takeshi Yoneda [email protected]