Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: implement SIMD Integer arithmetics #641

Merged
merged 2 commits into from
Jun 20, 2022
Merged

arm64: implement SIMD Integer arithmetics #641

merged 2 commits into from
Jun 20, 2022

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jun 20, 2022

This implements SIMD integer arithmetic instructions for arm64 backend.
Notably, now the engine passes simd_**_arith, simd_**_arith2, and
simd_**_sat_arith spectests.

part of #484

@@ -765,51 +765,6 @@ func TestAssemblerImpl_EncodeConstToRegister(t *testing.T) {
}
}

func TestAssemblerImpl_EncodeSIMDByteToSIMDByte(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are migrated to asm/arm64/impl_test.go

@mathetake mathetake marked this pull request as ready for review June 20, 2022 03:27
Signed-off-by: Takeshi Yoneda <[email protected]>
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the map arrangment better! keep it coming!

@mathetake mathetake merged commit 8a2776c into main Jun 20, 2022
@mathetake mathetake deleted the arithtttttttt branch June 20, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants