SIMD: implements comparison instructions #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok done with interpreter.... |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
commented
Jun 3, 2022
mathetake
commented
Jun 3, 2022
codefromthecrypt
approved these changes
Jun 3, 2022
| @@ -2180,6 +2180,198 @@ operatorSwitch: | |||
| c.emit( | |||
| &OperationV128Shr{Shape: ShapeI64x2, Signed: false}, | |||
| ) | |||
| case wasm.OpcodeVecI8x16Eq: | |||
There was a problem hiding this comment.
touch compiler_test.go each PR even if only one case
Co-authored-by: Crypt Keeper <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
|
will do the wazeroir/compiler_test backfilling in another PR as this is already huge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements all the vector comparison operators for the interpreter
and compiler(amd64).
Notably, now our engines pass
simd_*_cmp.wastspec tests.part of #484