Adds test delegating to iotest against a wasi fs.Fs implementation #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
wasifs
branch
2 times, most recently
from
de581b6 to
7853aaf
Compare
Signed-off-by: Anuraag Agrawal <[email protected]>
mathetake
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anuraag Agrawal [email protected]
Fixes #408
This implements
fs.Fsandio.Reader/io.Seekerby calling into exported wasm functions that delegate to wasi. This let's use add integration tests that targetfs.Fsas a generic mechanism for accessing files - in this PR we executeiotest.TestReaderwhich runs some tests verifying the operation of aReader. Because we haven't implementedfd_statin wasi yet, this does not implementFile.Stat()yet.https://cs.opensource.google/go/go/+/master:src/testing/iotest/reader.go;l=136