Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete reference types proposal #531

Merged
merged 6 commits into from
May 10, 2022
Merged

Complete reference types proposal #531

merged 6 commits into from
May 10, 2022

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented May 6, 2022 •
edited
Loading

This commit completes reference-types proposal implementation.
Notably, this adds support for

  • ref.is_null, ref.func, ref.is_null instructions
  • table.get, table.set, table.grow, table.size and table.fill instructions
  • Externref and Funcref types (including invocation via uint64 encoding).

part of #484

@mathetake
Copy link
Member Author

ok next is to implement table.get and table.set, then add more spectests

@mathetake
Copy link
Member Author

ok finished arm64... the next is to implement table.get set and ref.func on am64.

@tetratelabs tetratelabs deleted a comment from netlify bot May 9, 2022
@mathetake mathetake force-pushed the reftypespart1 branch 3 times, most recently from 43f86ec to f0ce773 Compare May 10, 2022 04:24
@mathetake mathetake marked this pull request as ready for review May 10, 2022 06:12
codefromthecrypt
codefromthecrypt approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. only found some holes around coverage on externref, if intentional please comment.

post merge I'll add an example, which can show why this is interesting to host function definers :D

internal/testing/enginetest/enginetest.go Show resolved Hide resolved
internal/wasm/binary/const_expr.go Show resolved Hide resolved
internal/wasm/func_validation_test.go Show resolved Hide resolved
internal/wasm/interpreter/interpreter.go Show resolved Hide resolved
internal/wasm/jit/jit_impl_amd64.go Show resolved Hide resolved
internal/wasm/module.go Show resolved Hide resolved
internal/wasm/module_test.go Show resolved Hide resolved
internal/wasm/store.go Show resolved Hide resolved
internal/wasm/table.go Show resolved Hide resolved
internal/wazeroir/operations.go Show resolved Hide resolved
mathetake added 3 commits May 10, 2022 17:41
@mathetake
more
6245c68 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
special
55afe96 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
table mutex
bb64146 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Copy link
Member Author

ok good to go!
img

@mathetake mathetake merged commit 20e46a9 into main May 10, 2022
@mathetake mathetake deleted the reftypespart1 branch May 10, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt