-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BSD to CI. #2338
Add BSD to CI. #2338
Conversation
Signed-off-by: Nuno Cruces <[email protected]>
I think we need these two to pass to say the core is working - what's the failing tests in there? |
A few more notes. This uses I'm planing a follow up PR that uses We can also use I am not testing multiple Go versions, nor am I installing a specific Go version; instead, I use the preinstalled GitHub Go version. Both these actions start a VM and rsync stuff into the VM. They don't know what exactly to copy, and they aren't very configurable here. If we install Go, they end up copying the entire local Linux Go installation into the VM for no reason. |
I can try to isolate the test cases. If you have any hints/suspicions, it'd be helpful. |
ok then we might need to try
|
Signed-off-by: Nuno Cruces <[email protected]>
Yeah, that fixes it! (sorry for the additional PR, it was meant to be on my fork, to run CI) |
Updated the initial comment, for more visibility of the current state of play. I'd like to highlight this: Users of these OSes that interested in fixing the actual WASI behaviour are encouraged to do so, then whitelist tests. They can run the tests locally with |
Signed-off-by: Nuno Cruces <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reflect the state of OS support in https://github.com/tetratelabs/wazero?tab=readme-ov-file#platform ?
Signed-off-by: Nuno Cruces <[email protected]>
This adds FreeBSD, OpenBSD, and NetBSD to CI.
The
weirdregex (imports|sysfs
) skips the following packages:internal/sysfs
experimental/sysfs
imports/assemblyscript
imports/assemblyscript/example
imports/emscripten
imports/wasi_snapshot_preview1
imports/wasi_snapshot_preview1/example
Mostly,
sysfs
and WASI need further work, even on FreeBSD.I propose we merge this as is, if for no other reason, to ensure no regressions. Later, we can figure out what needs to be fixed/skipped. Most of the issues are WASI details/intricacies.
Instead of using the regex, we should probably skip specific WASI tests. Either based on GOOS, or some
supports_X
(test?) flags. A bunch of tests fail because of non-portablestat
fields; others because of reduced file time resolution; etc.Users of these OSes that interested in fixing the actual behaviour are encouraged to do so, then whitelist tests.
Also: the fact wazero works and is used in these OSes with little to no complaints suggests these details don't matter that much in actual usage. WASI is complicated, our implementation of it is already very complex. It's also a preview.