Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: removes unnecessary ValueDefinition fields #2287

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jul 10, 2024

goos: darwin
goarch: arm64
pkg: github.com/tetratelabs/wazero
                      │  old.txt   │             new.txt              │
                      │   sec/op   │   sec/op    vs base              │
Compilation/wazero-10   1.541 ± 0%   1.535 ± 0%  -0.37% (p=0.015 n=6)
Compilation/zig-10      3.422 ± 0%   3.413 ± 0%  -0.27% (p=0.004 n=6)
Compilation/zz-10       14.10 ± 0%   14.08 ± 0%       ~ (p=0.310 n=6)
geomean                 4.205        4.194       -0.25%

                      │   old.txt    │              new.txt               │
                      │     B/op     │     B/op      vs base              │
Compilation/wazero-10   283.0Mi ± 0%   273.4Mi ± 0%  -3.38% (p=0.002 n=6)
Compilation/zig-10      596.7Mi ± 0%   594.7Mi ± 0%  -0.32% (p=0.002 n=6)
Compilation/zz-10       536.5Mi ± 0%   532.4Mi ± 0%  -0.76% (p=0.002 n=6)
geomean                 449.1Mi        442.4Mi       -1.50%

                      │   old.txt   │              new.txt              │
                      │  allocs/op  │  allocs/op   vs base              │
Compilation/wazero-10   485.4k ± 0%   485.2k ± 0%       ~ (p=0.394 n=6)
Compilation/zig-10      275.5k ± 0%   275.5k ± 0%       ~ (p=0.974 n=6)
Compilation/zz-10       627.0k ± 0%   627.1k ± 0%       ~ (p=0.145 n=6)
geomean                 437.7k        437.6k       -0.01%

#2182

@mathetake mathetake merged commit e2db5ac into main Jul 10, 2024
45 checks passed
@mathetake mathetake deleted the simplifies2222 branch July 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant