Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update #9

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

README update #9

wants to merge 7 commits into from

Conversation

rbndg
Copy link
Contributor

@rbndg rbndg commented Nov 14, 2024

  • Added docs for events and fundedTokenAddress event

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@bariscicek bariscicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated
@@ -15,8 +15,8 @@
"license": "APACHE-2.0",
"dependencies": {
"@ethereumjs/wallet": "^2.0.3",
"lib-wallet": "github:tetherto/lib-wallet#v0.0.1",
"wallet-seed-bip39": "github:tetherto/lib-wallet-seed-bip39#v0.0.1",
"lib-wallet": "github:rbndg/lib-wallet-main",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

@bariscicek bariscicek self-requested a review December 14, 2024 16:51
Copy link

@bariscicek bariscicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json

@@ -15,8 +15,8 @@
"license": "APACHE-2.0",
"dependencies": {
"@ethereumjs/wallet": "^2.0.3",
"lib-wallet": "github:tetherto/lib-wallet#v0.0.1",
"wallet-seed-bip39": "github:tetherto/lib-wallet-seed-bip39#v0.0.1",
"lib-wallet": "github:rbndg/lib-wallet-main#export-wallet",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we do that w/o pointing it to your repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants