-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javadoc for internal/Utils.java #3148
Conversation
WalkthroughThe updates involve changes at both the method and documentation levels within the TestNG project. The functionality of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
testng-core-api/src/main/java/org/testng/internal/Utils.java (2)
Line range hint
314-318
:
Ensure Javadoc matches the method functionality.The Javadoc states that the method returns a short stack trace, but the method is now intended to return a long stack trace.
- * Helper that returns a short stack trace. + * Helper that returns a long stack trace.
Line range hint
325-329
:
Ensure Javadoc matches the method functionality.The Javadoc states that the method returns a long stack trace, but the method is now intended to return a short stack trace.
- * Helper that returns a long stack trace. + * Helper that returns a short stack trace.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- testng-core-api/src/main/java/org/testng/internal/Utils.java (2 hunks)
Additional comments not posted (2)
testng-core-api/src/main/java/org/testng/internal/Utils.java (2)
Line range hint
314-319
:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
longStackTrace
match the new functionality.
Line range hint
325-330
:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
shortStackTrace
match the new functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are formatting issues because of which CI failed.
From the terminal/command prompt please run ./gradlew autostyleApply
to fix the formatting discrepancies, amend your commit, force push the changes and please let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- testng-core-api/src/main/java/org/testng/annotations/Test.java (1 hunks)
Files skipped from review due to trivial changes (1)
- testng-core-api/src/main/java/org/testng/annotations/Test.java
Holly guacamole! I just wanted a quick fix via web UI. |
@vlad8x8 - Thank you for taking the time to help raise this PR. |
Fixes # .
Did you remember to?
CHANGES.txt
./gradlew autostyleApply
We encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.
Summary by CodeRabbit
Bug Fixes
longStackTrace
andshortStackTrace
methods to ensure proper stack trace formatting.Documentation
name
attribute in the@Test
annotation for more accurate usage.