refactor: reorganize tests for key event behavior #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad21859:
|
Codecov Report
@@ Coverage Diff @@
## beta #863 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 82
Lines 1717 1717
Branches 614 614
=========================================
Hits 1717 1717 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refactor tests for the default behavior of key events.
Why:
The implementation how events are dispatched and the default behavior is triggered was changed in #838 .
The implementation how the DOM was manipulated due to user input was cleaned up in #851 .
The relationship between requirements as described by the tests and implementing modules was unclear.
Many tests mixing unrelated aspects of the software make it hard to distinguish between desirable changes and regressions.
Checklist: