Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: streamline tests for maxlength support #860

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Focus tests for maxlength support on the tested aspects.

Why:

Tests included huge snapshots that would change on unrelated code changes.

Checklist:

  • Tests
  • Ready to be merged

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Feb 23, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95fa7b0:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #860 (95fa7b0) into beta (376e6b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #860   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           82        82           
  Lines         1717      1717           
  Branches       614       614           
=========================================
  Hits          1717      1717           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376e6b3...95fa7b0. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 5ea38e8 into beta Feb 23, 2022
@ph-fritsche ph-fritsche deleted the refactor branch February 23, 2022 14:15
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

🎉 This PR is included in version 14.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant